Adjust Talkbuchet to be runnable with different parameters #7116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Until now the script had to be edited to set the right configuration parameters and then copied and pasted on the browser console; running the script again required reloading the page and pasting it again, even if the parameters where not modified. Now the constants were changed to variables and helper functions were added to set them, so the script can be pasted without changes and the configuration can be adjusted by calling the helper functions. Moreover, as there is now an explicit function to start the siege the script can be run several times and with different parameters without having to reload the page and paste it again. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
deleted the
adjust-talkbuchet-to-be-runnable-with-different-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the script had to be edited to set the right configuration parameters and then copied and pasted on the browser console; running the script again required reloading the page and pasting it again, even if the parameters where not modified.
Now the constants were changed to variables and helper functions were added to set them, so the script can be pasted without changes and the configuration can be adjusted by calling the helper functions. Moreover, as there is now an explicit function to start the siege the script can be run several times and with different parameters without having to reload the page and paste it again.