[stable24] Fix endless offer requests with the SIP bridge #7288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the HPB is used the data channel messages need to be sent through the publisher peer. Due to a wrong condition if there was no publisher peer they tried to be sent using the data channels of the subscribers, but those messages were simply ignored. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
"enableDataChannels" prevented the messages to be sent when the data channels were disabled, but it did not prevent the data channels from being created. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The SIP bridge publisher does not have data channels, so they need to be explicitly disabled in the subscriber. Otherwise it would try to open them, which would cause an endless loop of renegotiations, as after a negotiation the data channels will still not be opened, which will trigger a negotiation again. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot-nextcloud
bot
added
bug
feature: call 📹
backportbot-nextcloud
bot
requested review from
danxuliu,
fancycode and
nickvergessen
nickvergessen
approved these changes
May 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #7257