Fix trying to use "remoteVideoBlocker" with local screens #7317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"remoteVideoBlocker" is set in the shared datas of all remote participants. However, "videoBottomBar" is used both for remote participants and for local screens, which do not have that attribute. Other uses of "remoteVideoBlocker" should be safe, as they are implicitly guarded by checking "!isScreen" in the template. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
/backport to stable24 |
nickvergessen
approved these changes
May 6, 2022
nickvergessen
deleted the
fix-trying-to-use-remotevideoblocker-with-local-screens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6862
Fixes #7316
This fixes a regression introduced in 114b83d
remoteVideoBlockeris set in the shared datas of all remote participants. However,videoBottomBaris used both for remote participants and for local screens, which do not have that attribute.Other uses of
remoteVideoBlockershould be safe, as they are implicitly guarded by checking!isScreenin the template.