Skip to content

[stable24] Use "all: true" for end meeting for everyone case #7385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
backportbot-nextcloud wants to merge 5 commits into from
Closed

[stable24] Use "all: true" for end meeting for everyone case #7385

backportbot-nextcloud wants to merge 5 commits into from

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 17, 2022 •
edited by nickvergessen
Loading

~~ ⚠️ This backport had conflicts and is incomplete ⚠️ ~~

backport of #6948

@nickvergessen @backportbot-nextcloud
Use "all: true" for end meeting for everyone case
3121f9d 
This is needed to prevent issues with the request body size:

POST https:\/\/192.168.178.101:18443\/api\/v1\/room\/3097975620`
resulted in a `413 Request Entity Too Large` response:\nRequest entity
too large

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen @backportbot-nextcloud
Handle "event.participants.update.all" in the web
503454c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen @backportbot-nextcloud
Require new HPB version
3e514ad 
Signed-off-by: Joas Schilling <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added bug feature: call 📹 Voice and video calls feature: meetings 📅 Covering the webinary usecase incl. Lobby feature: signaling 📶 Internal and external signaling backends labels May 17, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the 💛 Next Patch (24) milestone May 17, 2022
@nickvergessen nickvergessen marked this pull request as draft May 17, 2022 14:37
@nickvergessen
Copy link
Member

nickvergessen commented May 17, 2022

  • ⚠️ Not to be merged / released before 7th June

@nickvergessen
Copy link
Member

nickvergessen commented May 17, 2022

  • Instead of hard requiring the new version we should check the flag on spot? Otherwise we can't really do this

vitormattos
vitormattos approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@vitormattos vitormattos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds no more problems, all tests are ok, only the fixup now

@danxuliu
Ignore call signaling messages when not in a call
04eef8a 
This should have been part of 3af5e86, but the backport of #6948 was
not merged yet when the backport of #7799 was created.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@danxuliu
Copy link
Member

danxuliu commented Aug 26, 2022

#7799 changed the allUsersChangedInCallToDisconnected handler, but as this PR was not merged yet the change had to be extracted from #7803 to its own commit here.

@nickvergessen
Copy link
Member

nickvergessen commented Nov 3, 2022

Let's just skip this. 25+ is also fine

@nickvergessen nickvergessen deleted the backport/6948/stable24 branch May 2, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danxuliu danxuliu Awaiting requested review from danxuliu

@fancycode fancycode Awaiting requested review from fancycode

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug feature: call 📹 Voice and video calls feature: meetings 📅 Covering the webinary usecase incl. Lobby feature: signaling 📶 Internal and external signaling backends

Projects

None yet

Milestone

v14.0.6

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @danxuliu @vitormattos