Skip to content

Add username tooltip in left sidebar #7427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

Add username tooltip in left sidebar #7427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/LeftSidebar/ConversationsList/Conversation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

<template>
<ListItem :title="item.displayName"
:titleTooltip="{content: item.displayName, boundariesElement: boundariesElement}"
Copy link
Author

@ghost ghost May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:titleTooltip="{content: item.displayName, boundariesElement: boundariesElement}"
:titleTooltip="{content: item.displayName.length > 20 ? item.displayName : '', boundariesElement: boundariesElement}"

Should the tooltip display for any length name (follows the standard of the spreed right sidebar) or only for names above a certain character length (follows the standard of server user list)?

:class="{'unread-mention-conversation': item.unreadMention}"
:anchor-id="`conversation_${item.token}`"
:active="isActive"
Expand Down Expand Up @@ -128,6 +129,9 @@ export default {
},

computed: {
boundariesElement() {
return document.querySelector('#content-vue')
},

counterType() {
if (this.item.unreadMentionDirect || (this.item.unreadMessages !== 0 && this.item.type === CONVERSATION.TYPE.ONE_TO_ONE)) {
Expand Down