Improve new group conversation modal #7724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
commented
Aug 16, 2022
CarlSchwan
force-pushed
the
improve-new-group-conversation-modal
branch
from
715e046 to
2220b78
Compare
CarlSchwan
force-pushed
the
improve-new-group-conversation-modal
branch
from
2220b78 to
2037904
Compare
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
There seems to be a lot of stuff that needs to be addressed. Some server css interfering, and some code that we'll have to remove
nickvergessen
force-pushed
the
improve-new-group-conversation-modal
branch
from
95dbcd4 to
5d22317
Compare
6 tasks
- Use NcTextField for the search - Use NcCheckBoxRadioSwitch for the NewGroupConversation component Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
improve-new-group-conversation-modal
branch
from
5d22317 to
75af49c
Compare
Member
|
Rebased and fixed eslint. Merging now to improve screenshotability. Any issues need to be fixed in follow ups. |
30 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.