Add missing aria label to buttons to show conversation actions #7737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default aria label for actions is "Actions", but the default value is overriden to an empty string when used in a list item, so it needs to be explicitly set. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
|
I don't see the warning on my dev instance |
marcoambrosini
approved these changes
Aug 15, 2022
marcoambrosini
deleted the
add-missing-aria-label-to-buttons-to-show-conversation-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default aria label for actions is Actions, but the default value is overriden to an empty string when used in a list item, so it needs to be explicitly set.
Fixes the console warning
You need to fill either the text or the ariaLabel props in the button component.referred to the actions buttons. I have done it in Talk rather than in Nextcloud vue as having an empty aria label for list items seems to be an explicit decision, probably because the text would need to change depending on the list item context (Conversation actions, Mail actions and so on).I have noticed that the same aria label is used in the top bar. I guess that it is not a problem if they are not unique, but I do not know.