Fix missing tooltip directive in DeviceChecker #7740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
nickvergessen
approved these changes
Aug 16, 2022
Although the directive was missing the tooltips were still shown in the normal Talk UI; the tooltips were missing only when Talk was embedded in other apps, like the Files app. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
force-pushed
the
fix-missing-tooltip-directive-in-devicechecker
branch
from
45dff9a to
fb9f756
Compare
Member
|
Rebased due to conflict after #7735 |
Member
|
That also means backporting will fail and have to be done manually. |
nickvergessen
deleted the
fix-missing-tooltip-directive-in-devicechecker
branch
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the directive was missing the tooltips were still shown in the normal Talk UI; the tooltips were missing only when Talk was embedded in other apps, like the Files app.
How to test
Result with this pull request
The tooltips are shown on the buttons to enable/disable audio, video and background blur
Result without this pull request
The tooltips are not shown on the buttons to enable/disable audio, video and background blur; an error is shown in the console about a missing tooltip directive