Fix missing local media controls in public share sidebar #7741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
nickvergessen
approved these changes
Aug 16, 2022
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Could do:
<CallButton v-if="!isInCall" class="call-button" />Now so there are not 2 "Leave call" buttons in the sidebar UI.
nickvergessen
deleted the
fix-missing-local-media-controls-in-public-share-sidebar
branch
This comment was marked as resolved.
This comment was marked as resolved.
4 similar comments
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
/backport to stable24 |
Member
|
/backport to stable24 |
Member
|
/backport to stable24 |
1 task
Member
Author
|
/backport to stable23 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
Result with this pull request
The local video controls can be used to enable/disable audio and video
Result without this pull request
The local video controls are not shown, so audio and video can not be enabled/disabled