Fix remote screen shares not shown in sidebar #7742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the call view is shown in the sidebar there is no button to share the screen. However, other participants can nevertheless open the call from the main Talk UI and share their screen there, so remote screen shares should be shown even if local ones can not be started. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
|
From my POV we could even block screenshares in the sidebar. Unless you can full screen the call view, they make little sense. |
nickvergessen
approved these changes
Aug 16, 2022
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
|
The backport to stable23 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3563
When the call view is shown in the sidebar there is no button to share the screen. However, other participants can nevertheless open the call from the main Talk UI and share their screen there, so remote screen shares should be shown even if local ones can not be started.
Before:
After:
