Skip to content

Use DisplayNameCache #7750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 4 commits into from
Aug 17, 2022
Merged

Use DisplayNameCache #7750

nickvergessen merged 4 commits into from
Aug 17, 2022

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Aug 16, 2022 •
edited by nickvergessen
Loading

Reduce query by 1/3 when fetching the list of rooms on the production
instance.

TODO:

@CarlSchwan CarlSchwan self-assigned this Aug 16, 2022
@CarlSchwan CarlSchwan mentioned this pull request Aug 16, 2022
Merged
@CarlSchwan CarlSchwan added this to the 💚 Next Beta (25) milestone Aug 16, 2022
@CarlSchwan CarlSchwan force-pushed the performance/optimize-retrival-of-rooms branch from 13529f0 to 7ca26f3 Compare August 16, 2022 10:13
nickvergessen
nickvergessen requested changes Aug 16, 2022
View reviewed changes
@CarlSchwan CarlSchwan force-pushed the performance/optimize-retrival-of-rooms branch from 7ca26f3 to 785b7d4 Compare August 16, 2022 10:51
@nickvergessen nickvergessen added feature: api 🛠️ OCS API for conversations, chats and participants and removed deployed on testing labels Aug 16, 2022
icewind1991
icewind1991 reviewed Aug 16, 2022
View reviewed changes
@CarlSchwan CarlSchwan force-pushed the performance/optimize-retrival-of-rooms branch from 39eeed0 to 2385df7 Compare August 16, 2022 12:59
nickvergessen
nickvergessen reviewed Aug 16, 2022
View reviewed changes
@CarlSchwan CarlSchwan force-pushed the performance/optimize-retrival-of-rooms branch 2 times, most recently from 0d00495 to 7794972 Compare August 17, 2022 08:28
CarlSchwan and others added 4 commits August 17, 2022 10:31
@CarlSchwan @nickvergessen
Use DisplayNameCache
2e2ab82 
Reduce query by 1/3 when fetching list of rooms on the production
instance

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan @nickvergessen
Use new OCP api
197c143 
Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan @nickvergessen
Add display name cache to SystemMessage
36f511d 
Signed-off-by: Carl Schwan <[email protected]>
@nickvergessen
Fix CS
724db04 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the performance/optimize-retrival-of-rooms branch from 7794972 to 724db04 Compare August 17, 2022 08:31
PVince81
PVince81 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvergessen nickvergessen merged commit 5871010 into master Aug 17, 2022
@nickvergessen nickvergessen deleted the performance/optimize-retrival-of-rooms branch August 17, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

Assignees

@CarlSchwan CarlSchwan

Labels

4. to release feature: api 🛠️ OCS API for conversations, chats and participants performance 🚀

Projects

None yet

Milestone

v15.0.0-beta.2

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan @nickvergessen @PVince81 @icewind1991