Skip to content

Ensure that the reactions array is always a JSON object #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Aug 22, 2022
Merged

Ensure that the reactions array is always a JSON object #7752

nickvergessen merged 1 commit into from
Aug 22, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 16, 2022 •
edited by Ivansss
Loading

Fix #7751

  • Confirmation from @mahibi that it does not break Android
  • Confirmation from @Ivansss that it does not break iOS

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Aug 16, 2022
@nickvergessen nickvergessen added this to the 💚 Next Beta (25) milestone Aug 16, 2022
@nickvergessen nickvergessen mentioned this pull request Aug 16, 2022
Closed
@mahibi
Copy link

mahibi commented Aug 17, 2022 

* [ ]  Confirmation from @mahibi that it does not break Android

tested and works

@nickvergessen nickvergessen requested a review from Ivansss August 18, 2022 13:04
Ivansss
Ivansss approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍
(needs rebase)

@nickvergessen nickvergessen force-pushed the bugfix/7751/ensure-reactions-array-is-always-a-json-object branch from d6915fe to 9e1b19b Compare August 22, 2022 15:25
@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 22, 2022

Rebased to solve the conflict with #7771

@nickvergessen nickvergessen merged commit f5c87b4 into master Aug 22, 2022
@nickvergessen nickvergessen deleted the bugfix/7751/ensure-reactions-array-is-always-a-json-object branch August 22, 2022 17:05
@nickvergessen
Copy link
Member Author

nickvergessen commented Sep 1, 2022

/backport to stable24

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 1, 2022

The backport to stable24 failed. Please do this backport manually.

@nickvergessen nickvergessen mentioned this pull request Sep 13, 2022
Merged
@nickvergessen
Copy link
Member Author

nickvergessen commented Sep 13, 2022

Manual backport in #7899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ivansss Ivansss Ivansss approved these changes

+1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4. to release bug feature: api 🛠️ OCS API for conversations, chats and participants

Projects

None yet

Milestone

v15.0.0-beta.2

Development

Successfully merging this pull request may close these issues.

reactions in Talk API sometimes delivered as array, sometimes map

5 participants

@nickvergessen @mahibi @vitormattos @Ivansss