Skip to content

Conversation

@marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Aug 17, 2022

  • Add some feedback about what the user voted
  • Disallow submit empty vote
  • Display user's vote when going back to the voting page if user has voted

Ref #7795

@marcoambrosini marcoambrosini changed the title Fix modal not opening after poll creation Polls cleanup Aug 24, 2022
@marcoambrosini marcoambrosini force-pushed the feature/polls-follow-up branch 2 times, most recently from 5092bae to dc1cbd5 Compare August 24, 2022 16:34
@marcoambrosini marcoambrosini self-assigned this Aug 24, 2022
@marcoambrosini marcoambrosini force-pushed the feature/polls-follow-up branch from dc1cbd5 to 450d388 Compare August 25, 2022 11:07
@nickvergessen
Copy link
Member

nickvergessen commented Aug 25, 2022

  • I'm not sure anymore what the discussion about forcing focus was, but after "Add answer" should we focus the new input field? Or how likely is it that someone wants to use enter multiple times to create the answer fields first. Only matters for keyboard navigation as the mouse needs to be repositioned anyway.
  • After you just voted the modal has no closing X and 3 confusing options:
    • Dismiss => Will it revert my vote? Maybe it can be migrated to a closing X in the top right?
    • Change your vote
    • Close poll => It will close the modal, right? 😛 => Should be "End poll" as per feature review meeting we had with Android back then
    • Also the buttons have issues with translation length. Missing padding on first button and 3 lines on the second one just as samples from German:
      Bildschirmfoto vom 2022-08-25 16-59-53
  • When you voted there is no indication what you voted for. You have to use the "Edit" screen to see if you want to edit. See next screen, I voted 3 only. But all options with votes are primary color and presented the same way
  • Percentages should be rounded to 2 digits?
    Bildschirmfoto vom 2022-08-25 17-06-31
  • When a poll was ended, the system message should be visible
  • When a poll was ended it should say "Poll ended" not "You voted"
    Bildschirmfoto vom 2022-08-25 17-11-08
  • When someone else ends the poll and you then open it, you see the voting options, etc. Submitting yields an error in the top right which is okay, but there is no indication why that is. So the poll details need to be refreshed when the system message is received (and in case of ending it needs to be immediately not after 5 secs), so editing is aborted and not visible anymore.
  • For non-moderators instead of "0 votes" we should say "You voted" in the summary line of private polls when the user voted already
  • Can not end a poll without voting

@marcoambrosini marcoambrosini force-pushed the feature/polls-follow-up branch from 40e1778 to 8689bbc Compare August 26, 2022 11:36
@nickvergessen nickvergessen self-requested a review August 26, 2022 14:51
@nickvergessen nickvergessen marked this pull request as ready for review August 26, 2022 14:51
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen merged commit 3a94a96 into master Aug 26, 2022
@nickvergessen nickvergessen deleted the feature/polls-follow-up branch August 26, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants