Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 26, 2022

Fix #7691

@fancycode
Copy link
Member

Tested, now shows Guest started a call (as is if dialed in without a pin). Is this expected or should it be the email address? Imho should be the email address as the user was invited.

@nickvergessen nickvergessen force-pushed the bugfix/7691/fix-email-invite-sipdial-in-systemmessages branch from ee45c74 to 9f7aa5f Compare August 30, 2022 08:30
@nickvergessen
Copy link
Member Author

Fixed unit tests and made emails return "Email (guest)" as default

@fancycode
Copy link
Member

Still shows only Guest for me. I updated to your latest commit, restarted php-fpm and rebuilt the JS. Browser cache is cleared. Anything else I'm missing?

@nickvergessen nickvergessen force-pushed the bugfix/7691/fix-email-invite-sipdial-in-systemmessages branch from 9f7aa5f to 23cac5b Compare August 30, 2022 09:19
@nickvergessen
Copy link
Member Author

Maybe git add on my site solves it 🤦🏼

$ git status
On branch bugfix/7691/fix-email-invite-sipdial-in-systemmessages
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   lib/Chat/Parser/SystemMessage.php

Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the email is now shown.

However when the call ends, the message says Call with 0 guests or Call with Username and 0 guests, i.e. the phone participant is not counted. Should I open a new issue for this or do you want to fix it here?

@nickvergessen
Copy link
Member Author

However when the call ends, the message says Call with 0 guests or Call with Username and 0 guests, i.e. the phone participant is not counted. Should I open a new issue for this or do you want to fix it here?

New issue please, thanks :)

@nickvergessen nickvergessen merged commit 0371fc3 into master Aug 30, 2022
@nickvergessen nickvergessen deleted the bugfix/7691/fix-email-invite-sipdial-in-systemmessages branch August 30, 2022 09:48
@fancycode
Copy link
Member

However when the call ends, the message says Call with 0 guests or Call with Username and 0 guests, i.e. the phone participant is not counted. Should I open a new issue for this or do you want to fix it here?

New issue please, thanks :)

#7825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong name in system message when guest starts call through dialin

3 participants