[stable24] Fix leaving room in one session causing call to be partially left in another session #7806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
added
bug
feature: signaling 📶
backportbot-nextcloud
bot
requested review from
danxuliu,
nickvergessen and
vitormattos
danxuliu
force-pushed
the
backport/7801/stable24
branch
from
6939831 to
ceb2073
Compare
When a call is left a message is sent to the external signaling server. However, that message is based on the sessions of the participants in the conversation. When a conversation is left and the participant was in a call in that conversation the call is also left, but the event was emitted after leaving the conversation. Due to that, when the message to be sent to the external signaling server was generated the participant was no longer in the conversation, and therefore it was not included in the message, so the call was not left from the point of view of the external signaling server. To solve that now the call is left and, once that is done, the conversation is left. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
When the same room is joined again from the same PHP session the room is left with the previous Nextcloud session before joining with the new one. However, "disinvite" messages were not sent to the external signaling server for regular users, so their UI was not updated to show that the previous Nextcloud session was kicked out from the conversation. Note, however, that as a "disinvite" message is now sent the UI will show a "conversation not found" message rather than a "duplicated session" state. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
backport/7801/stable24
branch
from
ab492c2 to
4844388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport had conflicts and is incompletebackport of #7801