Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 14, 2022

Fix #7826
Fix #7546

Patch for testing:

diff --git a/lib/Model/Message.php b/lib/Model/Message.php
index d888d0133..5e8202961 100644
--- a/lib/Model/Message.php
+++ b/lib/Model/Message.php
@@ -192,7 +192,7 @@ class Message {
                        'isReplyable' => $this->isReplyable(),
                        'referenceId' => (string) $this->getComment()->getReferenceId(),
                        'reactions' => $reactions,
-                       'expirationTimestamp' => $expireDate ? $expireDate->getTimestamp() : 0,
+                       'expirationTimestamp' => time() + 5, //$expireDate ? $expireDate->getTimestamp() : 0,
                ];
 
                if ($this->getMessageType() === ChatManager::VERB_MESSAGE_DELETED) {
diff --git a/src/components/MessagesList/MessagesList.vue b/src/components/MessagesList/MessagesList.vue
index 0bd7b689d..293fa616c 100644
--- a/src/components/MessagesList/MessagesList.vue
+++ b/src/components/MessagesList/MessagesList.vue
@@ -272,7 +272,7 @@ export default {
                 */
                this.expirationInterval = window.setInterval(() => {
                        this.removeExpiredMessagesFromStore()
-               }, 30000)
+               }, 3000) // FIXME }, 30000)
        },
 
        beforeDestroy() {

Remaining issue for a follow up:

@nickvergessen nickvergessen force-pushed the bugfix/7826/remove-expired-messages-from-store branch from dd7784d to 273985c Compare September 14, 2022 13:11
@nickvergessen nickvergessen changed the title Remove expired message from the Vue store Remove expired message and when there are too many from the Vue store Sep 14, 2022
@nickvergessen nickvergessen merged commit 0c7b35e into master Sep 14, 2022
@nickvergessen nickvergessen deleted the bugfix/7826/remove-expired-messages-from-store branch September 14, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expired chat messages are not removed from web UI store Unload chat messages to retain performance

3 participants