Skip to content

Fix missing bottom+right frame when following in a 2 person call #7929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcoambrosini merged 1 commit into from
Sep 15, 2022
Merged

Fix missing bottom+right frame when following in a 2 person call #7929

marcoambrosini merged 1 commit into from
Sep 15, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 15, 2022

Fix #7879

Steps

  1. Start a group call
  2. Join with a second user
  3. Switch to grid view
  4. Click on the other participant
  5. Check your frame
  6. Unfollow
  7. Check the frame again
Before After
Bildschirmfoto vom 2022-09-15 09-51-30 Bildschirmfoto vom 2022-09-15 09-50-58
Bildschirmfoto vom 2022-09-15 09-51-36 Bildschirmfoto vom 2022-09-15 09-51-03

@nickvergessen nickvergessen added this to the 💚 Next RC (25) milestone Sep 15, 2022
danxuliu
danxuliu approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

Backports? It is reproducible in Talk 14, and this seems to be a follow up to #6573, so it is probably reproducible as well in Talk 13 (but I have not checked).

@marcoambrosini marcoambrosini merged commit c206098 into master Sep 15, 2022
@marcoambrosini marcoambrosini deleted the bugfix/7879/fix-missing-frame-when-following-in-one-to-one branch September 15, 2022 11:07
@nickvergessen
Copy link
Member Author

nickvergessen commented Sep 15, 2022 •
edited
Loading

Backports? It is reproducible in Talk 14, and this seems to be a follow up to #6573, so it is probably reproducible as well in Talk 13 (but I have not checked).

No, too little impact and no one heavily noticed it in almost than 1 year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@danxuliu danxuliu danxuliu approved these changes

Assignees

No one assigned

Labels

3. to review bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v15.0.0-beta.4

Development

Successfully merging this pull request may close these issues.

followed participant is not "framed" like the current speaker in the speaker mode.

4 participants

@nickvergessen @marcoambrosini @danxuliu