Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 19, 2022

Fix #7952

Check result of both curl commands before and after:

# json
curl -k -u admin:admin \
    'https://nextcloud25.local/ocs/v2.php/apps/spreed/api/v1/chat/7d85h4a9?setReadMarker=0&lookIntoFuture=0&lastKnownMessageId=201&includeLastKnown=1' \
    -H 'OCS-APIRequest: true' \
    -H 'Accept: application/json, text/plain, */*' \
    | jq .


# xml
curl -k -u admin:admin \
    'https://nextcloud25.local/ocs/v2.php/apps/spreed/api/v1/chat/7d85h4a9?setReadMarker=0&lookIntoFuture=0&lastKnownMessageId=201&includeLastKnown=1' \
    -H 'OCS-APIRequest: true'

(Adjust domain and token and make sure the json one still returns an empty object for reactions

@nickvergessen nickvergessen added this to the 💚 Next RC (25) milestone Sep 19, 2022
@nickvergessen nickvergessen added feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Sep 19, 2022
@nickvergessen
Copy link
Member Author

cc @meonkeys

@nickvergessen nickvergessen force-pushed the bugfix/7952/fix-XML-endpoint-with-empty-reactions branch from 1870b79 to e612037 Compare September 20, 2022 12:27
@nickvergessen nickvergessen force-pushed the bugfix/7952/fix-XML-endpoint-with-empty-reactions branch from e612037 to 8a4bd00 Compare September 20, 2022 13:20
@nickvergessen nickvergessen self-assigned this Sep 20, 2022
@nickvergessen nickvergessen merged commit 1c497bd into master Sep 20, 2022
@nickvergessen nickvergessen deleted the bugfix/7952/fix-XML-endpoint-with-empty-reactions branch September 20, 2022 15:29
@nickvergessen
Copy link
Member Author

/backport to stable24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages

Projects

None yet

3 participants