Skip to content

Fix console error '[vuex] duplicate getter key: reactionsLoaded' in jest #7968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcoambrosini merged 1 commit into from
Sep 21, 2022
Merged

Fix console error '[vuex] duplicate getter key: reactionsLoaded' in jest #7968

marcoambrosini merged 1 commit into from
Sep 21, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 21, 2022 

console.error
      [vuex] duplicate getter key: reactionsLoaded

      915 | 			testStoreConfig.modules.messagesStore.getters.reactionsLoaded = reactionsLoadedGetter
      916 |
    > 917 | 			store = new Store(testStoreConfig)
          | 			        ^
      918 |
      919 | 			const messagePropsWithReactions = Object.assign({}, messageProps)
      920 | 			messagePropsWithReactions.reactions = { '❤️': 1 }

      at registerGetter (node_modules/vuex/dist/vuex.common.js:878:15)
      at node_modules/vuex/dist/vuex.common.js:751:5
      at node_modules/vuex/dist/vuex.common.js:125:52
          at Array.forEach (<anonymous>)
      at forEachValue (node_modules/vuex/dist/vuex.common.js:125:20)
      at Module.forEachGetter (node_modules/vuex/dist/vuex.common.js:200:5)
      at installModule (node_modules/vuex/dist/vuex.common.js:749:10)
      at node_modules/vuex/dist/vuex.common.js:755:5
      at node_modules/vuex/dist/vuex.common.js:125:52
          at Array.forEach (<anonymous>)
      at forEachValue (node_modules/vuex/dist/vuex.common.js:125:20)
      at Module.forEachChild (node_modules/vuex/dist/vuex.common.js:195:3)
      at installModule (node_modules/vuex/dist/vuex.common.js:754:10)
      at new Store (node_modules/vuex/dist/vuex.common.js:422:3)
      at _callee10$ (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:917:12)
      at tryCatch (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:51:2404)
      at Generator._invoke (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:51:1964)
      at Generator.next (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:51:3255)
      at asyncGeneratorStep (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:53:103)
      at _next (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:55:194)
      at src/components/MessagesList/MessagesGroup/Message/Message.spec.js:55:364
      at Object.<anonymous> (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:55:97)

    console.error
      [vuex] duplicate getter key: userHasReacted

      915 | 			testStoreConfig.modules.messagesStore.getters.reactionsLoaded = reactionsLoadedGetter
      916 |
    > 917 | 			store = new Store(testStoreConfig)
          | 			        ^
      918 |
      919 | 			const messagePropsWithReactions = Object.assign({}, messageProps)
      920 | 			messagePropsWithReactions.reactions = { '❤️': 1 }

      at registerGetter (node_modules/vuex/dist/vuex.common.js:878:15)
      at node_modules/vuex/dist/vuex.common.js:751:5
      at node_modules/vuex/dist/vuex.common.js:125:52
          at Array.forEach (<anonymous>)
      at forEachValue (node_modules/vuex/dist/vuex.common.js:125:20)
      at Module.forEachGetter (node_modules/vuex/dist/vuex.common.js:200:5)
      at installModule (node_modules/vuex/dist/vuex.common.js:749:10)
      at node_modules/vuex/dist/vuex.common.js:755:5
      at node_modules/vuex/dist/vuex.common.js:125:52
          at Array.forEach (<anonymous>)
      at forEachValue (node_modules/vuex/dist/vuex.common.js:125:20)
      at Module.forEachChild (node_modules/vuex/dist/vuex.common.js:195:3)
      at installModule (node_modules/vuex/dist/vuex.common.js:754:10)
      at new Store (node_modules/vuex/dist/vuex.common.js:422:3)
      at _callee10$ (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:917:12)
      at tryCatch (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:51:2404)
      at Generator._invoke (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:51:1964)
      at Generator.next (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:51:3255)
      at asyncGeneratorStep (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:53:103)
      at _next (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:55:194)
      at src/components/MessagesList/MessagesGroup/Message/Message.spec.js:55:364
      at Object.<anonymous> (src/components/MessagesList/MessagesGroup/Message/Message.spec.js:55:97)

@nickvergessen nickvergessen added this to the 💚 Next RC (25) milestone Sep 21, 2022
@nickvergessen nickvergessen self-assigned this Sep 21, 2022
@marcoambrosini marcoambrosini merged commit 4da50ea into master Sep 21, 2022
@marcoambrosini marcoambrosini deleted the bugfix/noid/fix-console-error-duplicate-getters branch September 21, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@nickvergessen nickvergessen

Labels

3. to review bug

Projects

None yet

Milestone

v15.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @marcoambrosini