Reduce two menus to one #8209
Merged
Reduce two menus to one #8209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
force-pushed
the
feature/6889/one-action-menu-only-in-calls
branch
2 times, most recently
from
55bbc7e to
980bcef
Compare
Member
Author
|
Current status: |
marcoambrosini
added
3. to review
design
enhancement
feature: frontend 🖌️
marcoambrosini
force-pushed
the
feature/6889/one-action-menu-only-in-calls
branch
from
980bcef to
cd99479
Compare
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
marcoambrosini
force-pushed
the
feature/6889/one-action-menu-only-in-calls
branch
from
cd99479 to
be67325
Compare
Member
|
When the right sidebar is open the seperator needs to go: While opening the menu the icon is invisible (but this is unchanged from #8019 )
|
nickvergessen
requested changes
Oct 26, 2022
Signed-off-by: Marco <[email protected]>
| @shortkey.native="toggleFullscreen"> | ||
| <!-- White icon if in call --> | ||
| <template v-if="isInCall" #icon> | ||
| <DotsHorizontal :size="20" |
Member
There was a problem hiding this comment.
Should we should the settings wheel as before in case it's not a call?
| 15.0.0 | This PR |
|---|---|
 |
 |
Member
Author
There was a problem hiding this comment.
I don't think so, as it contains (and will likely contain more) actions that are not settings
nickvergessen
approved these changes
Nov 7, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6889
Signed-off-by: Marco [email protected]