Do not show Talk sidebar if Talk is disabled for the user #8231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Joining a conversation in the public share page fails if Talk use is limited to certain groups and the public share page is opened by a user not in those groups. The incognito mode is enabled when the public share page is loaded, so from the point of view of the event handler that adds the Talk sidebar script the user is always a guest, and therefore adding the script can not be prevented for users not allowed to use Talk. Moreover, when those users tried to join the conversation in the public share page the button was kept disabled with a loading spinner forever, and no error was shown to the user. For simplicity, and as it could be useful if joining the conversation fails for any other reason, instead of looking for other ways to hide the Talk sidebar if the user is not allowed to use Talk now, if joining the conversation in the public share page fails, the button is restored and an error toast is shown. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
approved these changes
Oct 28, 2022
nickvergessen
deleted the
do-not-show-talk-sidebar-if-talk-is-disabled-for-the-user
branch
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending:
I have not checked if there is some way to know the actual user from the
TemplateLoader, but if not then at least an error should be shown when failing to join the conversation in the public share page (which should be shown nevertheless if there is an error independently of this issue, so maybe it would be the way to go).How to test (scenario 1)
Result with this pull request
The
Chattab is not shown in the sidebarResult without this pull request
The
Chattab is shown in the sidebarHow to test (scenario 2)
Result with this pull request
The button is restored and an error is shown
Result without this pull request
The button is kept disabled and with a loading spinner forever, and no error is shown to the user