Skip to content

Disable the dashboard widget with proper API #8239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Oct 31, 2022
Merged

Disable the dashboard widget with proper API #8239

nickvergessen merged 1 commit into from
Oct 31, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 28, 2022 •
edited
Loading

Follow up to #8233

Before

Log:

│[error] 2022-10-27T09:08:09.000 no app in contex Could not load lazy dashboard widget: OCA\Talk\Dashboard\TalkWidget

After

✨

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Oct 28, 2022
@nickvergessen nickvergessen added this to the 💟 Next Major (26) milestone Oct 28, 2022
@nickvergessen nickvergessen self-assigned this Oct 28, 2022
danxuliu
danxuliu approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 28, 2022

Psalm will fail until Sunday when the package is done, so will rebase on Monday

@danxuliu
Copy link
Member

danxuliu commented Oct 28, 2022 •
edited
Loading

psalm fails, is it just that the server API package was not updated yet or something else needs to be adjusted?

Edit: OK, answered xD

@nickvergessen nickvergessen force-pushed the followup/8233/disable-dashboard-widget-with-api branch from 766eee2 to 9006e98 Compare October 31, 2022 10:33
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 31, 2022

Cleanly rebased

@nickvergessen nickvergessen merged commit 1292604 into master Oct 31, 2022
@nickvergessen nickvergessen deleted the followup/8233/disable-dashboard-widget-with-api branch October 31, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danxuliu danxuliu danxuliu approved these changes

+1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nickvergessen nickvergessen

Labels

4. to release bug feature: api 🛠️ OCS API for conversations, chats and participants

Projects

None yet

Milestone

v16.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @danxuliu @vitormattos