Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 16, 2022

🚧 TODO

  • Rebased Added parameter to disallow creating of rooms with public access #8082 on latest master
  • Pushed to the organisation so we can all collaborate
  • Boolean config to enable and disable public conversations
  • Prevent creating such conversations via API
  • Don't allow adding email addresses which would also make the room public
  • Hide the option in the conversation creation dialog
  • Hide the option in the conversation settings
  • Add a config capability
  • Write integration tests for known API calls
    • Creation
    • Changing type
    • Inviting email

Follow up possible

  • Add an admin setting in the UI

🏁 Checklist

pboguslawski and others added 5 commits November 16, 2022 13:02
Added spreed application config parameter `public_rooms_allowed` to disallow
creating of rooms with public (guest via link) access (i.e. for internal
Nextcloud setups). Use

```
occ config:app:set spreed public_rooms_allowed --value 'yes'
```

to allow (default if not set) and

```
occ config:app:set spreed public_rooms_allowed --value 'no'
```

to disallow creating of rooms with public access.

Related: #521
Author-Change-Id: IB#1126215
Signed-off-by: Pawel Boguslawski <[email protected]>
…owed

Fixes: a38fdfd
Related: #8082 (review)
Author-Change-Id: IB#1126215
Signed-off-by: Pawel Boguslawski <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member Author

@pboguslawski shall we take over the remaining tasks?

@pboguslawski
Copy link
Contributor

No time resources now to help; feel free to adjust our PR according to your best practices. Will take a look at result in a few days. Thank you.

@pboguslawski
Copy link
Contributor

pboguslawski commented Jan 24, 2023

Didn't notice any problems in your solution.

shall we take over the remaining tasks

Yes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: settings ⚙️ Settings and config related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants