Split start conversation capability #8583
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitormattos
added
3. to review
feature: api 🛠️
vitormattos
force-pushed
the
feature/split-start-conversation
branch
from
2354752 to
4e9e74a
Compare
Member
|
When a user can not create a public/group conversation, they should also not be able to make an "Open conversation" which would allow others to join it too? |
Contributor
Author
|
Do you want to disallow to create 1-1 groups when haven't permission to create public conversation? |
Member
No, that's exactly the difference: 1-1 is not public |
Member
|
But then again the PR is not a priority at the moment. |
vitormattos
force-pushed
the
feature/split-start-conversation
branch
from
4e9e74a to
d95deef
Compare
Contributor
Author
|
Rebased with master to solve conflicts. |
Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
feature/split-start-conversation
branch
from
d95deef to
54e7b0c
Compare
Signed-off-by: Vitor Mattos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 TODO
🏁 Checklist
docs/has been updated or is not required