-
Notifications
You must be signed in to change notification settings - Fork 509
Set local video in Stripe to 4:3 aspect-ratio #8772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set local video in Stripe to 4:3 aspect-ratio #8772
Conversation
ShGKme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Steps to reproduce: |
|
I may admit that this may be a peculiarity of my environment... Does it work fine on yours? |
fb537c0 to
a62c711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, no cropping now. The aspect ratio is 1.33333 fallback until reconnecting and reopening the local video on my test.
I'm not sure if we want to merge it without solving #8815.
Yes, because videostream comes with |
Signed-off-by: Maksim Sukharev <[email protected]>
a62c711 to
5710ece
Compare







๐ผ๏ธ Screenshots
As mentioned in corellated issue #8815 :
Maximum capable video resolution is fixed at 4:3. This PR adjusts width and height of local video frame in stripe to fit in desired resolution and avoid its cropping
๐ง TODO
๐ Checklist
docs/has been updated or is not required