Enh/noid/use custom component for breakoutrooms #8919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
nickvergessen
approved these changes
Mar 2, 2023
Antreesy
reviewed
Mar 2, 2023
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
I'd like to go with proposed solution:
- if we want to add toggle logic to the rooms in the future;
- as rooms and participants are semantically different lists
Comment on lines
+24
to
+26
| <Fragment> | ||
| <li :key="roomName" | ||
| class="breakout-room-item"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <Fragment> | |
| <li :key="roomName" | |
| class="breakout-room-item"> | |
| <li :key="roomName"> | |
| <div class="breakout-room-item"> |
| <Participant :key="participant.actorId" :participant="participant" /> | ||
| </template> | ||
| </NcAppNavigationItem> | ||
| </Fragment> |
Contributor
There was a problem hiding this comment.
Suggested change
| </Fragment> | |
| </div> | |
| <ul class="breakout-room-item__participants"> | |
| <Participant v-for="participant in roomParticipants" | |
| :key="participant.actorId" | |
| :participant="participant" /> | |
| </ul> | |
| </li> |
nickvergessen
deleted the
enh/noid/use-custom-component-for-breakoutrooms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes #8900