Skip to content

fix(strings): Typos and spelling #9307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silopolis wants to merge 1 commit into from
Closed

fix(strings): Typos and spelling #9307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/AdminSettings/MatterbridgeIntegration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export default {
async enableMatterbridgeApp() {
if (OC.PasswordConfirmation.requiresPasswordConfirmation()) {
OC.PasswordConfirmation.requirePasswordConfirmation(this.enableMatterbridgeAppCallback, {}, () => {
showError(t('spreed', 'An error occurred while installing the Matterbridge app'))
showError(t('spreed', 'An error occurred while installing the Matterbridge app.'))
Copy link
Member

@nickvergessen nickvergessen Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel trolled now.

cc @rakekniven @Valdnet #9288

I'm still waiting for the answer:

My question remains, when should the dot at the end of a full sentence be skipped and why?

Copy link
Contributor Author

@silopolis silopolis Apr 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that mate 🙏

Copy link
Member

@rakekniven rakekniven Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel trolled now.

cc @rakekniven @Valdnet #9288

I'm still waiting for the answer:

My question remains, when should the dot at the end of a full sentence be skipped and why?

I do not have an valid answer for you. Using "bauchgefühl" myself.

})
}

Expand All @@ -158,7 +158,7 @@ export default {
try {
await enableMatterbridgeApp()
} catch (e) {
showError(t('spreed', 'An error occurred while installing the Talk Matterbridge. Please install it manually'), {
showError(t('spreed', 'An error occurred while installing the Talk Matterbridge. Please install it manually.'), {
onClick: () => {
window.open('https://apps.nextcloud.com/apps/talk_matterbridge', '_blank')
},
Expand Down
2 changes: 1 addition & 1 deletion src/components/AdminSettings/RecordingServers.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export default {
return this.uploadLimit !== 0 && this.uploadLimit < 512 * (1024 ** 2)
},
uploadLimitWarning() {
return t('spreed', 'The PHP settings "upload_max_filesize" or "post_max_size" only will allow to upload files up to {maxUpload}.', {
return t('spreed', 'The PHP settings "upload_max_filesize" or "post_max_size" will allow to upload files up to {maxUpload} only.', {
maxUpload: formatFileSize(this.uploadLimit, true, true),
})
},
Expand Down