Fix toasts messages on Fullscreen mode #9325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
requested changes
Apr 17, 2023
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Mostly works, but one function is broken and JSDoc is not complete.
Alternative solution: to fix nextcloud-libraries/nextcloud-dialogs#380. Then we would only need to change the default container on fullscreen toggle.
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/noid/add-wrapper-for-toasts
branch
from
7cdb74e to
b599cb4
Compare
ShGKme
reviewed
Apr 28, 2023
Comment on lines
+259
to
+260
| setGlobalToastOptions({ selector: this.$store.getters.getMainContainerSelector().slice(1) }) | ||
Contributor
There was a problem hiding this comment.
I haven't tested yet, but it seems, it should be watch. Otherwise, it sets it once and doesn't update global selector with the getMainContainerSelector update.
nickvergessen
modified the milestones:
v18.0.0-beta.1,
💙 Next Beta (28),
💞 Next Major (29)
nickvergessen
modified the milestones:
v19.0.0-beta.3,
💞 Next Beta (29),
v19.0.0-beta.4,
💙 Next Major (30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
#content-vue(which fixes Fullscreen Mode)🚧 Tasks
🏁 Checklist
docs/has been updated or is not required