-
Notifications
You must be signed in to change notification settings - Fork 508
Typing indicators in chat [web client] #9344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b0f1a73 to
d72ce7a
Compare
d72ce7a to
6510aa5
Compare
|
| return 'X' | ||
| } | ||
| const customName = this.name !== t('spreed', 'Guest') ? this.name : '?' | ||
| const customName = this.name && this.name !== t('spreed', 'Guest') ? this.name : '?' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an effective change? What is the difference and is it needed to do this on stable26 and others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, then I guess it should be backported
…geForm.vue Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]> - declare translatePlural in d.ts file, improve indicator message - remove HTML tags from direct translations - escape HTML markdown in participant names
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
015e587 to
f3a0c4f
Compare
|
Rebased on top of signaling API, fix capabilities check visibility (in fixup commit) |
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine


☑️ Resolves
🖼️ Screenshots
🚧 Tasks
API part
Visual part
Overall
🏁 Checklist
docs/has been updated or is not required