[stable26] Fix json output #9405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#8404 Signed-off-by: Vitor Mattos <[email protected]>
Verified only if the output contain a common json simbols: list of
objects: [{
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Will be a bit complex to match a string with quote because the regex ignore quotes: ([^"]*). If we change the regex don't will be possible found the end of string and maybe we will need to change the delimiter of the json string: https://stackoverflow.com/questions/8533943/cucumber-fill-in-a-field-with-double-quote-in-it#8534220 I changed to accept the argument also as PyStringNode and don't need do nothin more inside the method because the PyStringNode class have a magich methdo __toString(). Signed-off-by: Vitor Mattos <[email protected]>
…string * Make the definition of steps more specific Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #9067