refactor: replace indexOf with includes
#9441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the use of `.indexOf` with `.includes` for cases where the method is used to check if an array contains a particular element. This results in improved code readability and better adherence to modern JavaScript best practices. The replaced code snippets include: - `.indexOf(...) === -1` - `.indexOf(...) > -1` - `.indexOf(...) >= 0` Signed-off-by: Eng Zer Jun <[email protected]>
Contributor
Hello! Thanks for efforts you did to make our product better! |
Antreesy
approved these changes
May 5, 2023
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Tests are passed, all entries also manually tested 🦭
Good job!
| methods: { | ||
| isParticipantTypeModerator(participantType) { | ||
| return [PARTICIPANT.TYPE.OWNER, PARTICIPANT.TYPE.MODERATOR, PARTICIPANT.TYPE.GUEST_MODERATOR].indexOf(participantType) !== -1 | ||
| return [PARTICIPANT.TYPE.OWNER, PARTICIPANT.TYPE.MODERATOR, PARTICIPANT.TYPE.GUEST_MODERATOR].includes(participantType) |
Contributor
There was a problem hiding this comment.
Note for myself @Antreesy:
method is not used in project since for a while, can be deleted
Contributor
There was a problem hiding this comment.
And there is also some indexOf in the project
Feel free to make another PR =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋, first-time contributor here.
This PR replaces the use of
.indexOfwith.includesfor cases where the method is used to check if an array contains a particular element. This results in improved code readability and better adherence to modern JavaScript best practices.The replaced code snippets include:
.indexOf(...) === -1.indexOf(...) !== -1.indexOf(...) > -1.indexOf(...) >= 0