Techdebt: add ESLint rules to prepare for Vue 3 migration #9457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :fill-color="'#FFCC00'" /> | ||
| <template #icon> | ||
| <Star v-if="item.isFavorite" :size="20" /> | ||
| <Star v-else :size="20" :fill-color="'#FFCC00'" /> |
Member
There was a problem hiding this comment.
Suggested change
| <Star v-else :size="20" :fill-color="'#FFCC00'" /> | |
| <Star v-else :size="20" fill-color="#FFCC00" /> |
😊
Contributor
Author
There was a problem hiding this comment.
I wanted to have this commit plain, having only one lint rule fix, related to the migration.
For this thing we can add a new rule with the auto fix.
Contributor
Author
|
Actually, it is ready to merge. Should we do it before the release? |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
techdebt/add-eslint-rules-for-vue3-preparation
branch
from
681d585 to
12242f9
Compare
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Contributor
Author
|
Rebased onto master, added a fix for tests |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
commented
May 5, 2023
Comment on lines
-24
to
-25
| <NcButton slot="trigger" | ||
| v-tooltip.bottom="t('spreed', 'Create a new group conversation')" |
Contributor
Author
There was a problem hiding this comment.
Note: slot="trigger" is just removed here. This button is not passed to any of the component's slots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Add ESLint rules for deprecated things from Vue 2.6 and using Vue 3 things available in Vue 2.7
Fix all errors.
🖼️ Screenshots
No changes