Skip to content

Prevent at all from non moderators #9464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vitormattos wants to merge 1 commit into from
Closed

Prevent at all from non moderators #9464

vitormattos wants to merge 1 commit into from

Conversation

@vitormattos
Copy link
Contributor

@vitormattos vitormattos commented May 5, 2023 •
edited
Loading

☑️ Resolves

🏁 Checklist

@vitormattos vitormattos added 2. developing feature: api 🛠️ OCS API for conversations, chats and participants php labels May 5, 2023
@vitormattos vitormattos added this to the 💜 Next Major (28) milestone May 5, 2023
@vitormattos vitormattos requested a review from nickvergessen May 5, 2023 15:33
@vitormattos vitormattos self-assigned this May 5, 2023
SystemKeeper
SystemKeeper reviewed May 5, 2023
View reviewed changes
nickvergessen
nickvergessen requested changes May 8, 2023
View reviewed changes
@vitormattos vitormattos force-pushed the feature/prevent-at-all-from-non-moderators branch from ee44b84 to bbefc29 Compare May 9, 2023 14:17
@vitormattos vitormattos marked this pull request as ready for review May 9, 2023 14:19
@vitormattos vitormattos requested a review from nickvergessen May 9, 2023 14:19
SystemKeeper
SystemKeeper reviewed May 10, 2023
View reviewed changes
nickvergessen
nickvergessen requested changes May 10, 2023
View reviewed changes
nickvergessen
nickvergessen requested changes May 10, 2023
View reviewed changes
vitormattos added a commit that referenced this pull request May 12, 2023
@vitormattos
Refactor to be possible idnetify who can mention all
280b3ce 
#9464 (comment)

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos requested a review from nickvergessen May 12, 2023 10:00
nickvergessen
nickvergessen reviewed May 12, 2023
View reviewed changes
@vitormattos vitormattos force-pushed the feature/prevent-at-all-from-non-moderators branch from 85907e4 to a2a9764 Compare May 12, 2023 10:24
nickvergessen
nickvergessen reviewed May 12, 2023
View reviewed changes
vitormattos added a commit that referenced this pull request May 12, 2023
@vitormattos
Remove default value
a33de07 
#9464 (comment)

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos requested a review from nickvergessen May 12, 2023 11:40
@nickvergessen
Copy link
Member

nickvergessen commented May 12, 2023

Looks good, but not approving until stable27 is branched off

nickvergessen pushed a commit that referenced this pull request May 23, 2023
@vitormattos @nickvergessen
Refactor to be possible idnetify who can mention all
98ef1e0 
#9464 (comment)

Signed-off-by: Vitor Mattos <[email protected]>
nickvergessen pushed a commit that referenced this pull request May 23, 2023
@vitormattos @nickvergessen
Remove default value
ce187ff 
#9464 (comment)

Signed-off-by: Vitor Mattos <[email protected]>
@nickvergessen nickvergessen force-pushed the feature/prevent-at-all-from-non-moderators branch from a33de07 to 9ff80b7 Compare May 23, 2023 11:02
@vitormattos @nickvergessen
Add test scenario to validate the @ALL in mention
252c149 
Check if non moderators can use `@all` when autocomplete mentions

Signed-off-by: Vitor Mattos <[email protected]>
@nickvergessen nickvergessen force-pushed the feature/prevent-at-all-from-non-moderators branch from 9ff80b7 to 252c149 Compare May 23, 2023 11:03
@nickvergessen
Copy link
Member

nickvergessen commented May 23, 2023

  • Raise client and frontend issues

@nickvergessen nickvergessen changed the title Feature/prevent at all from non moderators Prevent at all from non moderators May 26, 2023
@nickvergessen
Copy link
Member

nickvergessen commented May 26, 2023

  • Currently messages still post and show the @all afterwards in the chat, so it's not clear to the user that actually no one was alerted.

@nickvergessen nickvergessen marked this pull request as draft May 26, 2023 12:22
@nickvergessen
Copy link
Member

nickvergessen commented Oct 10, 2023

Closing due to conflicts and absence of the dev

@nickvergessen nickvergessen deleted the feature/prevent-at-all-from-non-moderators branch October 10, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@nickvergessen nickvergessen

Labels

4. to release feature: api 🛠️ OCS API for conversations, chats and participants php

Projects

None yet

Milestone

v18.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Allow to prevent @all for non-moderators

4 participants

@vitormattos @nickvergessen @SystemKeeper