[stable26] fix closing the left sidebar on click automatically #9519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Simon L <[email protected]>
szaimen
previously approved these changes
May 11, 2023
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
tested and works but didnt review the code
nickvergessen
dismissed
szaimen’s stale review
Dismissing so Maksim has to review it
Antreesy
approved these changes
May 11, 2023
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Code is unchanged, except for emit declaration
Manually tested on stable26
Contributor
|
Seema like drone is stuck? |
Contributor
|
Can someone please restart drone? |
Member
|
I did |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport was fixed. From the initial PR only https://github.com/nextcloud/spreed/pull/9508/files#diff-1fdf1c31db343519a9914fec9debc8bbbfc0cfdf82a94a67d5658071349650a5L183-L184 is missing which is not existing on stable26
backport of #9508