Skip to content

fix(settings): Fix recording server check for blocked admins #9524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
May 12, 2023
Merged

fix(settings): Fix recording server check for blocked admins #9524

nickvergessen merged 1 commit into from
May 12, 2023

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 12, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
grafik grafik

🏁 Checklist

@nickvergessen nickvergessen added 3. to review bug feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants labels May 12, 2023
@nickvergessen nickvergessen added this to the 💙 Next Beta (27) milestone May 12, 2023
@nickvergessen nickvergessen requested a review from vitormattos May 12, 2023 09:36
@nickvergessen nickvergessen self-assigned this May 12, 2023
@nickvergessen
Copy link
Member Author

nickvergessen commented May 12, 2023

/backport to stable26

vitormattos
vitormattos approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@vitormattos vitormattos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshot at issue description, not only on PR moment would helped a lot.

Maybe this would be a good practice at our issues when is possible.

@nickvergessen nickvergessen enabled auto-merge May 12, 2023 10:47
@nickvergessen nickvergessen merged commit 56b5ff0 into master May 12, 2023
@nickvergessen nickvergessen deleted the bugfix/9416/fix-recording-server-welcome-for-blocked-admins branch May 12, 2023 11:04
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nickvergessen nickvergessen

Labels

3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: settings ⚙️ Settings and config related issues

Projects

None yet

Milestone

v17.0.0-beta.3

Development

Successfully merging this pull request may close these issues.

Unknown error at connectivity check with Recording Backend when user is not in "Limit to Groups" list

3 participants

@nickvergessen @vitormattos