Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Code review
  • Visual check

🏁 Checklist

@nickvergessen nickvergessen merged commit 7e9803f into master May 12, 2023
@nickvergessen nickvergessen deleted the fix/9430/follow-ups-from-refactoring branch May 12, 2023 20:51
@ShGKme
Copy link
Contributor

ShGKme commented May 12, 2023

I re-checked, and I was a bit wrong in that comment.

It is not directly mentioned in the Vue documentation, but if a custom event has a native event object as a payload, its native event modifiers still do work on custom component events (most of the modifiers, incl. prevent, exact, stop).

Prooflink

Although, it changes almost nothing. I checked all the cases. In all the cases .prevent was useless because its target had no default event handler anyway (button[type="button"], div, esc for input). The only difference is exact. Now these buttons in the danger zone work also with CTRL/SHIFT/ALT key modifiers.

image

cc @Antreesy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants