Skip to content

Add main container id to the store for sidebars #9531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
May 12, 2023
Merged

Add main container id to the store for sidebars #9531

nickvergessen merged 1 commit into from
May 12, 2023

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented May 12, 2023

☑️ Resolves

🚧 Tasks

  • Visual check

🏁 Checklist

@Antreesy
add main container id to the store
f39d36e 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added 3. to review regression feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels May 12, 2023
@Antreesy Antreesy added this to the 💜 Next Major (28) milestone May 12, 2023
@Antreesy Antreesy requested a review from danxuliu May 12, 2023 19:24
@Antreesy Antreesy self-assigned this May 12, 2023
@Antreesy Antreesy requested a review from nickvergessen May 12, 2023 19:24
@Antreesy
Copy link
Contributor Author

Antreesy commented May 12, 2023

/backport to stable26

nickvergessen
nickvergessen approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@nickvergessen nickvergessen merged commit 17d31e9 into master May 12, 2023
@nickvergessen nickvergessen deleted the fix/9529/restore-new-message-form-in-sidebars branch May 12, 2023 20:55
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@Antreesy Antreesy

Labels

3. to review feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents regression

Projects

None yet

Milestone

v18.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

New message form is not shown in the Talk sidebar of public shares and video verification

3 participants

@Antreesy @nickvergessen