Adjust ip ranges to reduce noise in random traning data #1018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the huge address space that IPv6 has, 7 out of 8 addresses will probably never be seen in real world login attempts which could reduce the effectiveness of the trained model.
I wondered if I should include the LLA fe80::/10 (well /64 really per spec), but decided against it, because these aren't the addresses we want to protect against as they are purely local and on a server setup very unlikely. (No router must be involved)
Also, I decided against ULA fc00::/7 because these would probably be more used within a company and then the other training approach of scrambling valid login attempts with other users' IP addresses would be the better method.
And so I focused only on 2000::/4 as this is the dangerous internet, as we currently know it.
Right now, this is totally untested because I am mainly looking for feedback for this approach. What do you think?
This would close #959