feat: Public sharing via link #2236

enjeck · 2025-12-28T07:23:06Z

part of #67

TODO

Ensure password protected shares work one the backend implements that enh(Sharing): backend infrastructre for read-only link shares #2211
Show the table/view name, emoji and description once I confirm we get it from the backend

src/modules/main/sections/PublicElement.vue

lib/Controller/PageController.php

src/App.vue

src/modules/sidebar/partials/SharingEntryLink.vue

lib/Controller/PageController.php

enjeck · 2026-01-06T05:51:59Z

Now looks like this:

- modifies oc_tables_share structure with two columns, token and password - adds ShareOCSController with a route to create link shares - adds a PageController front route to display the link share - adds a ApiPublicColumnsController to retrieve columns for public links. It was not added to the existing ApiColumnsController, as it requires the userId of the logged-in user and I did not want to weaken this detail. - adds an abstract controller for columns with shared functionality and make ApiColumnsController extend it. - adds a PublicRowOCSController for retrieving rows through link shares - adds a ShareToken value object - adds a ShareControlMiddleware for share token and existance validation. It comes with the AssertShareToken attribute. - extends Share entity with ShareToken and Password properties - extends ShareMapper to find a share by the share token - extends ShareService with a method to easily create link shares - extends ResponseDefinitions with TablesPublicRow and TablesPublicColumn specs. Essentially tableIDs are not exposed and also user ids in lastEditBy and createdBy are not disclosed. - extends RowService and ColumnService with methods to return such ^ formatted result arrays. - extends OpenAPI spec Signed-off-by: Arthur Schiwon <[email protected]>

Signed-off-by: Arthur Schiwon <[email protected]>

- reuses existing logic and templates from server, cf. OCP\AppFramework\AuthPublicShareController Signed-off-by: Arthur Schiwon <[email protected]>

- modifies oc_tables_share structure with two columns, token and password - adds ShareOCSController with a route to create link shares - adds a PageController front route to display the link share - adds a ApiPublicColumnsController to retrieve columns for public links. It was not added to the existing ApiColumnsController, as it requires the userId of the logged-in user and I did not want to weaken this detail. - adds an abstract controller for columns with shared functionality and make ApiColumnsController extend it. - adds a PublicRowOCSController for retrieving rows through link shares - adds a ShareToken value object - adds a ShareControlMiddleware for share token and existance validation. It comes with the AssertShareToken attribute. - extends Share entity with ShareToken and Password properties - extends ShareMapper to find a share by the share token - extends ShareService with a method to easily create link shares - extends ResponseDefinitions with TablesPublicRow and TablesPublicColumn specs. Essentially tableIDs are not exposed and also user ids in lastEditBy and createdBy are not disclosed. - extends RowService and ColumnService with methods to return such ^ formatted result arrays. - extends OpenAPI spec Signed-off-by: Arthur Schiwon <[email protected]>

Signed-off-by: Enjeck C. <[email protected]>

enjeck · 2026-01-09T07:43:12Z

The share link is not created correctly, at least when NC is installed in a subdir, see the duplicated nextcloud section:

https://example.org/nextcloud/nextcloud/index.php/apps/tables/s/rXPTiveyDC5t4SID

Should be fixed now @blizzz

blizzz

Works! Some cosmetic remarks. I skimmed front-end code only tbh.

blizzz · 2026-01-09T17:53:32Z

lib/Controller/ApiColumnsController.php

 * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */
+


I think all the changes in this file are not necessary?

blizzz · 2026-01-09T17:54:54Z

lib/Controller/PageController.php

 		protected IInitialState $initialState,
 		protected ShareService $shareService,
 		protected NodeService $nodeService,
+		protected IL10N $l,


We don't need it and its use clause here anymore

blizzz · 2026-01-09T17:56:13Z

lib/Controller/PublicSharePageController.php

+		$token = $request->getParam('token');
+		if (is_string($token) && $token !== '') {
+			$this->shareToken = new ShareToken($token);
+			try {


Can we not have this try block? Or why do we need it? Properties should not be nullable ideally.

blizzz · 2026-01-09T17:57:55Z

lib/Controller/PublicSharePageController.php

 	public function isValidToken(): bool {
-		$this->shareToken;
-		return true;
+		return $this->share !== null;


Ah, yeah, my code was a leftover after refactoring. Before it would fetch it, and succeed, or fail. If we need this than the nullable approach is ok for now.

blizzz · 2026-01-09T17:58:36Z

lib/ResponseDefinitions.php

+ * @psalm-type TablesPublicNode = array{
+ *  title: string,
+ *  emoji: string,
+ *  description: string,
+ *  createdAt: string,
+ *  lastEditAt: string,
+ *  rowsCount: int,
+ * }
+ *


goes away, openapi ci will complain when it is not used in the spec.

blizzz · 2026-01-09T18:00:54Z

src/shared/utils/shareUtils.js

+
+/**
+ * Checks if a share is a public link share
+ * @param {object} share


there is some jsdoc warning ☝️ 🤷

enjeck self-assigned this Dec 28, 2025

enjeck added this to 📝 Office team Dec 28, 2025

enjeck requested a review from blizzz as a code owner December 28, 2025 07:23

github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Dec 28, 2025

enjeck commented Dec 28, 2025

View reviewed changes

src/modules/main/sections/PublicElement.vue Show resolved Hide resolved

enjeck force-pushed the enh/noid/link-share-biz branch from 9f86cfc to 6cc82e6 Compare December 29, 2025 16:16

enjeck requested a review from juliusknorr December 30, 2025 08:33

enjeck commented Dec 30, 2025

View reviewed changes

lib/Controller/PageController.php Outdated Show resolved Hide resolved

juliusknorr reviewed Dec 30, 2025

View reviewed changes

src/App.vue Outdated Show resolved Hide resolved

juliusknorr reviewed Dec 30, 2025

View reviewed changes

src/modules/sidebar/partials/SharingEntryLink.vue Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

juliusknorr added the enhancement New feature or request label Dec 30, 2025

juliusknorr reviewed Dec 30, 2025

View reviewed changes

lib/Controller/PageController.php Outdated Show resolved Hide resolved

blizzz force-pushed the enh/noid/link-share-biz branch from 6cc82e6 to 7858b90 Compare January 5, 2026 11:05

enjeck force-pushed the public-share-fe branch from aa519cf to c598627 Compare January 6, 2026 03:36

enjeck force-pushed the enh/noid/link-share-biz branch from 0078f8d to 28fa2e9 Compare January 7, 2026 02:12

enjeck force-pushed the public-share-fe branch from 1181f56 to 06729a5 Compare January 7, 2026 03:41

This comment was marked as resolved.

Sign in to view

blizzz added 2 commits January 8, 2026 14:52

style(PHP): adjust according to php-cs-fixer

9c86190

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz force-pushed the enh/noid/link-share-biz branch 3 times, most recently from ea6afca to 0a12b1b Compare January 8, 2026 14:26

enh(Sharing): handle password protected shares

fb4223f

- reuses existing logic and templates from server, cf. OCP\AppFramework\AuthPublicShareController Signed-off-by: Arthur Schiwon <[email protected]>

blizzz force-pushed the enh/noid/link-share-biz branch from 0a12b1b to fb4223f Compare January 8, 2026 14:50

blizzz and others added 4 commits January 9, 2026 05:44

fixup! enh(Sharing): backend infrastructre for read-only link shares

54db06b

feat: Public sharing via link

2044dbf

Signed-off-by: Enjeck C. <[email protected]>

enjeck added 7 commits January 9, 2026 05:46

tests(Cypress): add public link share

ac2b76d

Signed-off-by: Enjeck C. <[email protected]>

enh: Rename component

e4cafb4

Signed-off-by: Enjeck C. <[email protected]>

fix: Improve UI

34de6a3

Signed-off-by: Enjeck C. <[email protected]>

fix: Move error styles

679ea4d

Signed-off-by: Enjeck C. <[email protected]>

enh: Use emoji, title, description

521732d

Signed-off-by: Enjeck C. <[email protected]>

tests(Cypress): Password protected shares

339a12f

Signed-off-by: Enjeck C. <[email protected]>

fix: check for null token

554bf99

Signed-off-by: Enjeck C. <[email protected]>

enjeck force-pushed the public-share-fe branch from 06729a5 to 554bf99 Compare January 9, 2026 07:19

fix: Use window origin for share link

2137993

Signed-off-by: Enjeck C. <[email protected]>

blizzz approved these changes Jan 9, 2026

View reviewed changes

enjeck force-pushed the enh/noid/link-share-biz branch from fb4223f to f567947 Compare January 9, 2026 19:29

blizzz force-pushed the enh/noid/link-share-biz branch from f567947 to 434fc6a Compare January 9, 2026 22:24

feat: Public sharing via link #2236

Are you sure you want to change the base?

feat: Public sharing via link #2236

Uh oh!

Conversation

enjeck commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

enjeck commented Jan 6, 2026

Uh oh!

This comment was marked as resolved.

enjeck commented Jan 9, 2026

Uh oh!

blizzz left a comment

Choose a reason for hiding this comment

Uh oh!

blizzz Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

enjeck commented Dec 28, 2025 •

edited

Loading