Perf: Optimize FE performance of inline edit with rich text editor #2240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjeck
force-pushed
the
feature/speedup-inline-edit-for-rich-editor
branch
from
6fdb05c to
0bd34f3
Compare
juliusknorr
approved these changes
Jan 9, 2026
Koc
force-pushed
the
feature/speedup-inline-edit-for-rich-editor
branch
from
0bd34f3 to
e45828c
Compare
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
enjeck
force-pushed
the
feature/speedup-inline-edit-for-rich-editor
branch
from
e45828c to
7e247e9
Compare
enjeck
approved these changes
Jan 12, 2026
Contributor
|
/backport to stable1.0 |
|
The backport to # Switch to the target branch and update it
git checkout stable1.0
git pull origin stable1.0
# Create the new backport branch
git checkout -b backport/2240/stable1.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7e247e91
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2240/stable1.0Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a large table with many multi line text fields. The problem is that currently
RichEditorcomponent created too early (even before we start editing field). And this early creation adds an tons of event listeners to handle click outside. And sometimes it sends too many updates to BE (even if field wasn't changed).My PR delays creation of the
RichEditorcomponent: now we creating it only for inline editing, not earlier.Related to #2212 and #2174