Skip to content

[stable1.0] feat: lazy initialization for editor setup #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enjeck merged 2 commits into from
Jan 16, 2026
Merged

[stable1.0] feat: lazy initialization for editor setup #2251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d1fe5b
feat: lazy initialization for editor setup
enjeck Dec 9, 2025
6868616
enh: Remove resizeobserver fallback
enjeck Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Controller/PageController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ public function index(): TemplateResponse {
Util::addStyle(Application::APP_ID, 'grid');
Util::addStyle(Application::APP_ID, 'modal');
Util::addStyle(Application::APP_ID, 'tiptap');
Util::addStyle(Application::APP_ID, 'tables-style');

if (class_exists(LoadViewer::class)) {
$this->eventDispatcher->dispatchTyped(new LoadViewer());
Expand Down
28 changes: 25 additions & 3 deletions src/shared/components/ncEditor/NcEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ export default {
textAppAvailable: !!window.OCA?.Text?.createEditor,
editor: null,
localValue: '',
observer: null,
initialized: false,
}
},

Expand Down Expand Up @@ -96,16 +98,36 @@ export default {

async mounted() {
this.localValue = this.text
await this.setupEditor()
this.editor?.setContent(this.localValue, false)
this.setupLazyInitialization()
},

beforeDestroy() {
this?.editor?.destroy()
this?.observer?.disconnect?.()
this?.editor?.destroy?.()
},

methods: {
t,
setupLazyInitialization() {
if (this.initialized) return

this.observer = new IntersectionObserver((entries) => {
for (const entry of entries) {
if (entry.isIntersecting && !this.initialized) {
this.initialized = true
this.setupEditor().then(() => {
this.editor?.setContent(this.localValue, false)
})
this.observer?.disconnect?.()
break
}
}
}, { rootMargin: '200px' })
this.$nextTick(() => {
const el = this.$el
if (el) this.observer.observe(el)
})
},
async setupEditor() {
this?.editor?.destroy()
if (this.textAppAvailable) {
Expand Down
Loading