#1424: Add Tables to user_migration #2292
Conversation
samin-z
changed the title
| { | ||
| $item = new Column(); | ||
| $item->setTableId($table->getId()); | ||
| $item->setTitle($column['title']); |
There was a problem hiding this comment.
I'm not 100% sure with the abstraction layers in the tables app but you could probably shorten this by using https://github.com/nextcloud/server/blob/master/lib/public/AppFramework/Db/Entity.php#L51-L62
$item = Column::fromRow($column);
Please verify though, setTableId may need separate handling still.
lib/Service/ContextService.php
Outdated
| $newContext->setName($context['name'] ?? ''); | ||
| $newContext->setIcon($context['iconName'] ?? ''); | ||
| $newContext->setDescription($context['description'] ?? ''); | ||
| $newContext->setOwnerId($context['owner'] ?? ''); |
There was a problem hiding this comment.
If we import, do we set the old owner id? Or would be be needed to change this to the current user id of the importer instead? Same probably applies to other importers
There was a problem hiding this comment.
@juliusknorr this was actually one of the final fixes im making, im going to actually check if the user exist and if not then use current logged in user, what do you think about that? or should we go straight with the current user?
There was a problem hiding this comment.
We should always use the user that is importing as the new owner (as I assume only your own tables/context are exported). The current logged in user may not work as I assume it is importing in a background job?
But I would guess there is a way to get the "target" user as part of the import process of the user_migration app
There was a problem hiding this comment.
understandable, i'm currently working on that.
lib/TablesMigrator.php
Outdated
| public function __construct( | ||
| IL10N $l10n, | ||
| TableMapper $tableMapper, | ||
| ColumnMapper $columnMapper, | ||
| RowSleeveMapper $rowSleeveMapper, | ||
| ViewMapper $viewMapper, | ||
| ContextMapper $contextMapper, | ||
| ShareMapper $shareMapper, | ||
| ContextNodeRelationMapper $contextNodeRelationMapper, | ||
| FavoritesService $favoritesService, |
There was a problem hiding this comment.
Add ability to export/import user tables.