Fix scroll on embedded widget and adjust height to screen size#2808
Open
taiebot wants to merge 1 commit into
Open
Fix scroll on embedded widget and adjust height to screen size#2808taiebot wants to merge 1 commit into
taiebot wants to merge 1 commit into
Conversation
Signed-off-by: taiebot <dedreuil@yahoo.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
Fix #2596 another solution to #2744
This has been tested on multiple scenarios.
With ClaudeAI i have done multiple tests cases and this is the solution i came up with.
The table widget embedded in Nextcloud Text/Collectives had several visual bugs when scrolling and missed the three dots to manage the widget. After this PR the widget renders properly.
Interactive cells (star ratings, URLs, richtext editors) scrolled over the sticky header (title + search bar) instead of passing underneath it
The widget had a fixed height of 50vh with no adaptation to screen size
On iOS/iPad, the widget scroll captured the entire page scroll
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)
What is still broken on embedded table and not part of this pr