Skip to content

Conversation

@mahibi
Copy link
Collaborator

@mahibi mahibi commented Sep 21, 2022

see nextcloud/spreed#7959

Signed-off-by: Marcel Hibbe [email protected]

@mahibi mahibi self-assigned this Sep 21, 2022
@mahibi mahibi added this to the 15.0.0 milestone Sep 21, 2022
@mahibi mahibi added the 3. to review Waiting for reviews label Sep 21, 2022
@mahibi mahibi requested a review from timkrueger September 21, 2022 10:18
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings112112
Errors11

SpotBugs (new)

Warning Type Number
Bad practice Warnings 4
Correctness Warnings 33
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 10
Performance Warnings 22
Security Warnings 2
Dodgy code Warnings 54
Total 136

SpotBugs (master)

Warning Type Number
Bad practice Warnings 4
Correctness Warnings 33
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 10
Performance Warnings 22
Security Warnings 2
Dodgy code Warnings 54
Total 136

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2414-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@timkrueger timkrueger modified the milestones: 15.0.0, 15.1.0 Sep 23, 2022
@timkrueger
Copy link
Contributor

/backport to stable-15.0


private fun loadAvatarForStatusBar() {
if (inOneToOneCall() && activity != null) {
if (isOneToOneConversation() && activity != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good alignment 👍

@timkrueger timkrueger merged commit 009dbaf into master Sep 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/hidePollCreationForOneToOne branch September 23, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants