Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving search for chat messages #4647

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jan 23, 2025

🚧 TODO

  • Got the dialog set up
  • Get API working
  • Adapter?
  • Improving Links
  • System Messages
  • getting the conversation name
  • Optimization.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Jan 23, 2025
@rapterjet2004 rapterjet2004 self-assigned this Jan 23, 2025
- Updated api with getContextForChatMessages
- Added ContextChatCompose for viewing the context of messages
- Added ComposeChatAdapter, a reimplementation of chat adapter
- Helper functions

Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 force-pushed the issue-4433-improve-search-for-chat-messages branch from bc5d207 to 4c00ddc Compare March 7, 2025 18:29
@rapterjet2004 rapterjet2004 marked this pull request as ready for review March 7, 2025 18:48
Signed-off-by: rapterjet2004 <[email protected]>
Copy link
Contributor

github-actions bot commented Mar 7, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4647-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Codacy

Lint

TypemasterPR
Warnings100100
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222226
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310314

SpotBugs increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve search for chat messages
1 participant