-
-
Notifications
You must be signed in to change notification settings - Fork 294
feat: Add deep link and launcher shortcut support for conversations #5664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
angrymuesli
wants to merge
1
commit into
nextcloud:master
Choose a base branch
from
angrymuesli:feature/deep-link-launcher-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124 changes: 124 additions & 0 deletions
124
app/src/main/java/com/nextcloud/talk/utils/DeepLinkHandler.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| /* | ||
| * Nextcloud Talk - Android Client | ||
| * | ||
| * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: GPL-3.0-or-later | ||
| */ | ||
| package com.nextcloud.talk.utils | ||
|
|
||
| import android.net.Uri | ||
|
|
||
| /** | ||
| * Handles parsing of deep links for opening conversations. | ||
| * | ||
| * Supported URI formats: | ||
| * - nctalk://conversation/{token} | ||
| * - nctalk://conversation/{token}?user={internalUserId} | ||
| * - https://{server}/call/{token} | ||
| * - https://{server}/index.php/call/{token} | ||
| */ | ||
| object DeepLinkHandler { | ||
|
|
||
| private const val SCHEME_NCTALK = "nctalk" | ||
| private const val HOST_CONVERSATION = "conversation" | ||
| private const val QUERY_PARAM_USER = "user" | ||
| private const val PATH_CALL = "call" | ||
| private const val PATH_INDEX_PHP = "index.php" | ||
|
|
||
| /** | ||
| * Result of parsing a deep link URI. | ||
| * | ||
| * @property roomToken The conversation/room token to open | ||
| * @property internalUserId Optional internal user ID for multi-account support | ||
| * @property serverUrl Optional server URL extracted from web links | ||
| */ | ||
| data class DeepLinkResult( | ||
| val roomToken: String, | ||
| val internalUserId: Long? = null, | ||
| val serverUrl: String? = null | ||
| ) | ||
|
|
||
| /** | ||
| * Parses a deep link URI and extracts conversation information. | ||
| * | ||
| * @param uri The URI to parse | ||
| * @return DeepLinkResult if the URI is valid, null otherwise | ||
| */ | ||
| fun parseDeepLink(uri: Uri): DeepLinkResult? { | ||
| return when (uri.scheme?.lowercase()) { | ||
| SCHEME_NCTALK -> parseNcTalkUri(uri) | ||
| "http", "https" -> parseWebUri(uri) | ||
| else -> null | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Parses a custom scheme URI (nctalk://conversation/{token}). | ||
| */ | ||
| private fun parseNcTalkUri(uri: Uri): DeepLinkResult? { | ||
| if (uri.host?.lowercase() != HOST_CONVERSATION) { | ||
| return null | ||
| } | ||
|
|
||
| val pathSegments = uri.pathSegments | ||
| if (pathSegments.isEmpty()) { | ||
| return null | ||
| } | ||
|
|
||
| val token = pathSegments[0] | ||
| if (token.isBlank()) { | ||
| return null | ||
| } | ||
|
|
||
| val userId = uri.getQueryParameter(QUERY_PARAM_USER)?.toLongOrNull() | ||
|
|
||
| return DeepLinkResult( | ||
| roomToken = token, | ||
| internalUserId = userId | ||
| ) | ||
| } | ||
|
|
||
| /** | ||
| * Parses a web URL (https://{server}/call/{token} or https://{server}/index.php/call/{token}). | ||
| */ | ||
| private fun parseWebUri(uri: Uri): DeepLinkResult? { | ||
| val path = uri.path ?: return null | ||
| val host = uri.host ?: return null | ||
|
|
||
| // Match /call/{token} or /index.php/call/{token} | ||
| val tokenRegex = Regex("^(?:/$PATH_INDEX_PHP)?/$PATH_CALL/([^/]+)/?$") | ||
| val match = tokenRegex.find(path) ?: return null | ||
| val token = match.groupValues[1] | ||
|
|
||
| if (token.isBlank()) { | ||
| return null | ||
| } | ||
|
|
||
| val serverUrl = "${uri.scheme}://$host" | ||
|
|
||
| return DeepLinkResult( | ||
| roomToken = token, | ||
| serverUrl = serverUrl | ||
| ) | ||
| } | ||
|
|
||
| /** | ||
| * Creates a custom scheme URI for a conversation. | ||
| * | ||
| * @param roomToken The conversation token | ||
| * @param internalUserId Optional user ID for multi-account support | ||
| * @return URI in the format nctalk://conversation/{token}?user={userId} | ||
| */ | ||
| fun createConversationUri(roomToken: String, internalUserId: Long? = null): Uri { | ||
| val builder = Uri.Builder() | ||
| .scheme(SCHEME_NCTALK) | ||
| .authority(HOST_CONVERSATION) | ||
| .appendPath(roomToken) | ||
|
|
||
| internalUserId?.let { | ||
| builder.appendQueryParameter(QUERY_PARAM_USER, it.toString()) | ||
| } | ||
|
|
||
| return builder.build() | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent filter for opening talk conversation links can be removed because it does not work for Android 12+ devices.