Skip to content

Optimize banning item layout #5828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AndyScherzinger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize banning item layout #5828

AndyScherzinger wants to merge 1 commit into from
+57 −72

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Feb 9, 2026

  • use typical 2 line item coloring and text sized
  • move padding to the item not the list

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Feb 9, 2026
@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews labels Feb 9, 2026
@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Feb 9, 2026

/backport to stable-23.0

@mahibi mahibi force-pushed the style/noid/banningItemLayout branch from 8aa8f09 to 190c394 Compare February 10, 2026 09:59
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Codacy

Lint

TypemasterPR
Warnings9899
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Lint increased!

@AndyScherzinger
style(banning): optimize banning item layout
abbb3c2 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the style/noid/banningItemLayout branch from 190c394 to abbb3c2 Compare February 10, 2026 13:20
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5828.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

No one assigned

Labels

3. to review Waiting for reviews backport-request design Related to the design

Projects

None yet

Milestone

23.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyScherzinger @mahibi