Skip to content

fix to set User-Agent for OTP logins - #6502

Merged
mahibi merged 1 commit into
masterfrom
bugfix/noid/fixToSetUserAgentForOTP
Aug 17, 2026
Merged

fix to set User-Agent for OTP logins#6502
mahibi merged 1 commit into
masterfrom
bugfix/noid/fixToSetUserAgentForOTP

Conversation

@mahibi

@mahibi mahibi commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

In https://github.com/nextcloud/talk-android/pull/6401/files it was forgotten to set the user agent for OTP logins. This commit fixes it.

That's the reason why in WebUI security settings, the app was identified as "okhttp/4.12.0" if the login ws done via QR code.

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

In https://github.com/nextcloud/talk-android/pull/6401/files it was forgotten to set the user agent for OTP logins. This commit fixes it.

Thats the reason why in WebUI security settings, the app was identified as "okhttp/4.12.0" if the login ws done via QR code.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added this to the 25.0.0 milestone Aug 17, 2026
@mahibi
mahibi requested a review from rapterjet2004 August 17, 2026 13:01
@mahibi mahibi self-assigned this Aug 17, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label Aug 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/32032811501/artifacts/9289751885
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi
mahibi merged commit 9c74435 into master Aug 17, 2026
17 of 20 checks passed
@mahibi
mahibi deleted the bugfix/noid/fixToSetUserAgentForOTP branch August 17, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants