fix(chat): derive call-started banner from live events, not loaded history - #6505
Closed
mahibi wants to merge 1 commit into
Closed
fix(chat): derive call-started banner from live events, not loaded history#6505mahibi wants to merge 1 commit into
mahibi wants to merge 1 commit into
Conversation
…story The call-started/ended banner was reconstructed by re-scanning whatever message window happened to be loaded (chat tail, an anchor/context jump, or a paginated history block). Since window contents don't correspond to "what actually just happened," this made the banner reappear for calls that had long since ended whenever an unrelated history load surfaced an old, dangling call_started. Replace that with an event stream: ChatMessageSyncer now reports a call system message via Events.onCallSystemMessage only when the containing batch is confirmed to reflect the conversation's true current tail — excluding bounded historical fetches (jump-to-message, backlog rounds that haven't caught up yet) and picking the chronologically last decisive message by id rather than trusting array order, since an unconditional "newest messages" fetch returns newest-first. ChatViewModel seeds the banner once from the initial tail load for instant display on open, then updates exclusively from the new callSystemMessageFlow. Assisted-by: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/32054891916/artifacts/9296249763 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. wont be merged as it's too complicated. It was just a try to derive call started messages reliably without room requests while fixing the current bugs it has.
Will be replaced by the simpler solution #6503
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)