[stable-25.0.x] Bugfix/6378/fix talk back for messages - #6615
Closed
backportbot[bot] wants to merge 2 commits into
Closed
[stable-25.0.x] Bugfix/6378/fix talk back for messages#6615backportbot[bot] wants to merge 2 commits into
backportbot[bot] wants to merge 2 commits into
Conversation
Message text was rendered via an AndroidView-hosted TextView, whose content never reached the merged accessibility node of the chat message row, so TalkBack only announced the timestamp and read status. Wrap it in a Box carrying the accessible text as contentDescription so it merges into the row's announcement like the existing time/status info, and hide the native TextView's own accessibility node to avoid a duplicate readout. Also stop TalkBack announcing "In list, N items" on every message: LazyColumn's default CollectionInfo makes it re-announce list entry on each focus change since items don't carry position info. Override it with a 1x1 CollectionInfo so TalkBack's own hasMultipleItems() check treats it as not a real countable collection. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de> Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33609350289/artifacts/9840638176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6610
Warning, This backport's changes differ from the original and might be incomplete鈿狅笍
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.